Move RTP timestamp members to Metadata objects#204
Conversation
|
@alvestrand @fippo explicitly |
alvestrand
left a comment
alvestrand
left a comment
There was a problem hiding this comment.
I think this is good. Want to have another pair of eyes on it before Thursday next week - @youennf ?
youennf
left a comment
youennf
left a comment
There was a problem hiding this comment.
LGTM.
I wonder what the transition plan is for shipping implementations.
Maybe the use is low enough that there is no need to keep both for some amount of time?
|
Thanks all!
My intention for chromium is to have both for some time. We don't have use counters yet though, so I'm not sure how long that would have to be. |
|
Sseveral CPaaS vendors have announced support for client side encryption which means an update cycle of at least six months I'd say. |
|
Editors meeting: Needs rebase, can be merged when rebased. |
tonyherre
force-pushed
the
move-rtp-timestamp
branch
from
43b8c59 to
3445b6f
Compare
tonyherre
force-pushed
the
move-rtp-timestamp
branch
from
3445b6f to
869a787
Compare
|
Rebased, thanks. |
SHA: e258de1 Reason: push, by alvestrand Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
I get validation failures in #140 due to the leftover RTCEncodedVideoFrame/timestamp et al which were removed here but that wasn't picked up by the validator so passed? |
…imestamp follow up to #204 fix CI error noted in #140 (comment)
…imestamp follow up to #204
|
Just saw this while maintaining https://github.com/microsoft/TypeScript-DOM-lib-generator/, is it safe to remove this without webcompat issue while it's shipped on every engine per MDN? |
…webidl moved and renamed in w3c/webrtc-encoded-transform#204 keeping the old name for backward compat. Differential Revision: https://phabricator.services.mozilla.com/D291455
5 participants
Fixes #203
Preview | Diff